🌱 Move catalogd controllers and webhooks to internal/catalogd #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
LalatenduMohanty
force-pushed
the
move_catalogd_controllers_webhooks
branch
from
c43707e to
2af8b64
Compare
LalatenduMohanty
changed the title
LalatenduMohanty
changed the title
joelanford
reviewed
Feb 12, 2025
joelanford
reviewed
Feb 12, 2025
joelanford
reviewed
Feb 12, 2025
LalatenduMohanty
force-pushed
the
move_catalogd_controllers_webhooks
branch
from
2af8b64 to
f3b166c
Compare
Moving catalogd/internal/controllers and catalogd/internal/webhooks to internal/catalogd along with the Makefile changes Signed-off-by: Lalatendu Mohanty <[email protected]>
LalatenduMohanty
force-pushed
the
move_catalogd_controllers_webhooks
branch
from
f3b166c to
d06df7f
Compare
As build-deps needs the generate target which has been moved to the root Makefile i.e. operator-controller/Makefile Signed-off-by: Lalatendu Mohanty <[email protected]>
|
I had to remove the |
LalatenduMohanty
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
=======================================
Coverage 67.45% 67.45%
=======================================
Files 61 61
Lines 5245 5245
=======================================
Hits 3538 3538
Misses 1446 1446
Partials 261 261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reviewer Checklist