Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 refactor catalogmetadata types used for resolution #599

Closed
wants to merge 3 commits into from

better type checking

32466fa
Select commit
Loading
Failed to load commit list.
Closed

🌱 refactor catalogmetadata types used for resolution #599

better type checking
32466fa
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 21, 2024 in 0s

80.98% (-3.55%) compared to ef06f40

View this Pull Request on Codecov

80.98% (-3.55%) compared to ef06f40

Details

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (ef06f40) 84.53% compared to head (32466fa) 80.98%.
Report is 30 commits behind head on main.

Files Patch % Lines
internal/catalogmetadata/client/client.go 66.66% 11 Missing and 1 partial ⚠️
...ternal/catalogmetadata/filter/bundle_predicates.go 28.57% 5 Missing ⚠️
internal/catalogmetadata/types.go 87.50% 3 Missing and 2 partials ⚠️
...nternal/controllers/clusterextension_controller.go 92.50% 3 Missing ⚠️
...al/resolution/variablesources/installed_package.go 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
- Coverage   84.53%   80.98%   -3.55%     
==========================================
  Files          20       20              
  Lines         931      936       +5     
==========================================
- Hits          787      758      -29     
- Misses        100      130      +30     
- Partials       44       48       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov