Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(paraglide-sveltekit): resolve type errors and infinite loops #3264

Conversation

onyedikachi-david
Copy link

Fix Svelte 5 Type Errors and Infinite Update Loops

Fixes opral/inlang-paraglide-js#262

Description

This PR fixes issues that emerged after upgrading @inlang/paraglide-sveltekit to 0.13.0 with Svelte 5:

  • TypeScript errors with derived values
  • Maximum update depth exceeded errors
  • Initialization issues causing infinite loops

Related Issues

Copy link

changeset-bot bot commented Dec 12, 2024

⚠️ No Changeset found

Latest commit: 1a59e09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@samuelstroschein
Copy link
Member

Will review/merge it on the weekend. @onyedikachi-david many thanks for the follow up PR!

@samuelstroschein
Copy link
Member

@onyedikachi-david thanks for the PR and your contribution. The PR has been succeeded by #3277.

  • infinite recursion still existed
  • alternate links component was not updated to runes

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ParaglideJS component needs to be updated to Svelte 5 logics
2 participants