Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Ax v0.3.7 #184

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Fix for Ax v0.3.7 #184

merged 4 commits into from
Mar 5, 2024

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented Mar 5, 2024

The latest Ax release has removed some low-level functions we were using to manually transition from Sobol to BO in the AxService generators. This PR simplifies the implementation and now uses functions that are still available in Ax v0.3.7.

@AngelFP AngelFP requested a review from MaxThevenet March 5, 2024 14:15
@AngelFP AngelFP enabled auto-merge March 5, 2024 14:21
Copy link
Collaborator

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AngelFP AngelFP merged commit f57175f into main Mar 5, 2024
8 checks passed
@MaxThevenet MaxThevenet deleted the bug/fix_new_ax branch March 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants