Skip to content

[FSSDK-11399] support traffic allocation for cmab #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 24, 2025
Merged

Conversation

raju-opti
Copy link
Contributor

Summary

support traffic allocation for cmab experiment rules. A bucket call is first made to check if the user is in the experiment before calling the cmab service.

Test plan

  • added test for cmab bucketing

Issues

  • FSSDK-11399

@coveralls
Copy link

coveralls commented Apr 22, 2025

Coverage Status

coverage: 80.714% (-0.04%) from 80.755%
when pulling 761180a on raju/cmab_traffic
into 85c0220 on master.

Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - lovely. Let me know about TDD name change in my comment.

@raju-opti raju-opti merged commit 6214c11 into master Apr 24, 2025
14 of 19 checks passed
@raju-opti raju-opti deleted the raju/cmab_traffic branch April 24, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants