Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: switch to exporter-toolkit, use std embed instead of go-bindata #16

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Breaking: switch to exporter-toolkit, use std embed instead of go-bindata #16

wants to merge 14 commits into from

Conversation

vooon
Copy link

@vooon vooon commented Oct 2, 2023

Changes:

  • BREAKING: use exporter-toolkit, changes flags parsing to kingpin, changes flag names to follow official *_exporter, e.g. node_exporter
  • Switched to std embed, added test, upgraded to yaml.v3
  • Added CI configs and GoReleaser to have prebuilt binaries in GH releases
  • Requires Go 1.21 because at some places i moved to use "log/slog".

Signed-off-by: Vladimir Ermakov [email protected]

@vooon
go.mod: update
513d2be
@vooon
ci: add goreleaser
77ff235
@vooon
replace go-bindata with std embed
59a13b0 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
use std slog, add config test, fix golangci-lint errors
7dbf9fb 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
go.mod: require 1.21 because of slog
61afe38
@vooon
ci: update lint go version
1537a39 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
port to prometheu exporter toolkit
9a5dd65 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
make lint happy
54ab95e 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
Merge pull request #1 from sardinasystems/use-embed
7b2310a 
Use embed
@vooon
readme: update
595b493 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
goreleaser: fix main file
f544f94
@vooon
goreleaser: fix .Env tempaltes
da07db3
@vooon
move config files to a config module to make goreleaser happy
c90eb40 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon
add sample unit file
c9b4b3f 
Signed-off-by: Vladimir Ermakov <[email protected]>
@vooon vooon changed the title Braking: switch to exporter-toolkit, use std embed instead of go-bindata Breaking: switch to exporter-toolkit, use std embed instead of go-bindata Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vooon