Merge pull request #138 from nabenabe0928/breaking/move-positional-ar…

…gs-of-lgbm-tuner Move positional args of LightGBM tuner
optuna · Jul 9, 2024 · f1076a6 · f1076a6
2 parents 214578c + b61a9a3
commit f1076a6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/optuna_integration/__init__.py b/optuna_integration/__init__.py
@@ -71,8 +71,8 @@
     from optuna_integration.catboost import CatBoostPruningCallback
     from optuna_integration.chainer import ChainerPruningExtension
     from optuna_integration.chainermn import ChainerMNStudy
-    from optuna_integration.comet import CometCallback
     from optuna_integration.cma import PyCmaSampler
+    from optuna_integration.comet import CometCallback
     from optuna_integration.dask import DaskStorage
     from optuna_integration.fastaiv2 import FastAIPruningCallback
     from optuna_integration.fastaiv2 import FastAIV2PruningCallback

diff --git a/optuna_integration/_lightgbm_tuner/_train.py b/optuna_integration/_lightgbm_tuner/_train.py
@@ -31,8 +31,8 @@ def train(
     study: Study | None = None,
     optuna_callbacks: list[Callable[[Study, FrozenTrial], None]] | None = None,
     model_dir: str | None = None,
-    show_progress_bar: bool = True,
     *,
+    show_progress_bar: bool = True,
     optuna_seed: int | None = None,
 ) -> "lgb.Booster":
     """Wrapper of LightGBM Training API to tune hyperparameters.

diff --git a/optuna_integration/_lightgbm_tuner/optimize.py b/optuna_integration/_lightgbm_tuner/optimize.py
@@ -363,9 +363,9 @@ def __init__(
         sample_size: int | None = None,
         study: optuna.study.Study | None = None,
         optuna_callbacks: list[Callable[[Study, FrozenTrial], None]] | None = None,
+        *,
         show_progress_bar: bool = True,
         model_dir: str | None = None,
-        *,
         optuna_seed: int | None = None,
     ) -> None:
         _imports.check()
@@ -736,8 +736,8 @@ def __init__(
         study: optuna.study.Study | None = None,
         optuna_callbacks: list[Callable[[Study, FrozenTrial], None]] | None = None,
         model_dir: str | None = None,
-        show_progress_bar: bool = True,
         *,
+        show_progress_bar: bool = True,
         optuna_seed: int | None = None,
     ) -> None:
         super().__init__(
@@ -919,10 +919,10 @@ def __init__(
         sample_size: int | None = None,
         study: optuna.study.Study | None = None,
         optuna_callbacks: list[Callable[[Study, FrozenTrial], None]] | None = None,
+        *,
         show_progress_bar: bool = True,
         model_dir: str | None = None,
         return_cvbooster: bool = False,
-        *,
         optuna_seed: int | None = None,
     ) -> None:
         super().__init__(

diff --git a/tests/lightgbm/test_optimize.py b/tests/lightgbm/test_optimize.py
@@ -6,7 +6,6 @@
 from typing import Any
 from typing import TYPE_CHECKING
 from unittest import mock
-import warnings
 
 import numpy as np
 import optuna