Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow recent changes in optuna/optuna's document sphinx config #197

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

nzw0301
Copy link
Member

@nzw0301 nzw0301 commented Jan 25, 2025

Motivation

Address #182 and optuna/optuna#5805.

Description of the changes

  • Update python 3.12 for sphinx-build
  • Introduce sphinx-notfound-page

@nzw0301 nzw0301 changed the title Use python 3.12 for sphinx-build Follow optuna/optuna's document sphinx config. Jan 25, 2025
@nzw0301 nzw0301 added the document Documentation related. label Jan 25, 2025
@nzw0301 nzw0301 marked this pull request as ready for review January 25, 2025 10:56
@nzw0301 nzw0301 changed the title Follow optuna/optuna's document sphinx config. Follow optuna/optuna's document sphinx config Jan 25, 2025
@nzw0301 nzw0301 changed the title Follow optuna/optuna's document sphinx config Follow recent changes in optuna/optuna's document sphinx config Jan 25, 2025
@nzw0301 nzw0301 linked an issue Jan 25, 2025 that may be closed by this pull request
@nabenabe0928
Copy link
Collaborator

@c-bata Could you review this PR?

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@c-bata c-bata added this to the v4.3.0 milestone Jan 28, 2025
@c-bata c-bata merged commit 374954e into optuna:main Jan 28, 2025
122 checks passed
@nzw0301 nzw0301 deleted the use-python-312-for-sphinx branch January 28, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Python 3.12 to build the documentation in CI
3 participants