Fix

optuna · Oct 24, 2024 · 2bfad4b · 2bfad4b
1 parent e9e7b95
commit 2bfad4b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/package/samplers/auto_sampler/sampler.py b/package/samplers/auto_sampler/sampler.py
@@ -211,8 +211,7 @@ def sample_independent(
         return self._sampler.sample_independent(study, trial, param_name, param_distribution)
 
     def before_trial(self, study: Study, trial: FrozenTrial) -> None:
-        # NOTE(nabenabe): Use the states used in IntersectionSearchSpace().calculate.
-        states_of_interest = [TrialState.COMPLETE, TrialState.WAITING, TrialState.RUNNING]
+        states_of_interest = [TrialState.COMPLETE, TrialState.WAITING]
         if len(study._get_trials(deepcopy=False, states=states_of_interest)) != 0:
             search_space = IntersectionSearchSpace().calculate(study)
             self._sampler = self._determine_sampler(study, trial, search_space)

diff --git a/package/samplers/auto_sampler/tests/test_auto_sampler.py b/package/samplers/auto_sampler/tests/test_auto_sampler.py
@@ -144,3 +144,6 @@ def test_choose_tpe_with_conditional_params() -> None:
     assert ["RandomSampler"] + ["GPSampler"] * 15 + ["TPESampler"] * (
         n_trials - 16
     ) == sampler_names
+
+
+# TODO: Add a test with enqueue_trial.