Add plot for runtime benchmarking #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y0z
reviewed
Jul 29, 2024
There was a problem hiding this comment.
Could you run pre-commit to your code to pass the checks CI?
https://github.com/optuna/optunahub-registry/actions/runs/10141190091/job/28037907857?pr=109
|
Probably, it is nicer to have a guidance to pre-commit in the PR template. To merge this PR, please use $ pip install pre-commit
$ pre-commit run --all-files |
y0z
reviewed
Jul 30, 2024
| from matplotlib.axes._axes import Axes | ||
|
|
||
|
|
||
| def objective(trial: optuna.Trial) -> float: |
There was a problem hiding this comment.
Perhaps this objective function can be removed.
nabenabe0928
commented
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Motivation
This PR is to add a plot to compare multiple samplers' runtime.
Description of the changes