Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the comment format and make typing stricter in SMACSampler #174

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

nabenabe0928
Copy link
Contributor

Contributor Agreements

Please read the contributor agreements and if you agree, please click the checkbox below.

  • I agree to the contributor agreements.

Motivation

This PR refactors the comments of SMAC and makes the static typing slightly stricter.

@nabenabe0928 nabenabe0928 changed the title Refactor SMACSampler Unify the comment format and make typing stricter in SMACSampler Nov 8, 2024
@nabenabe0928
Copy link
Contributor Author

@y0z
Could you review this PR?

Copy link
Member

@y0z y0z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@y0z y0z merged commit b883957 into optuna:main Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants