-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Optuna Visualization with Advanced Plotting for Optimization History #182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
To merge this PR, several fixes are needed.
Please update your PR following the comments below.
- Please move the
optuna_enhanced_visualization
directory underoptunahub-registry/package/visualization
like this. - Please do not change
.pre-commit-config.yaml
in this PR since it is irrelevant to your visualization package. - optuna_enhanced_visualization/example.py and test_optu.py can be removed.
The following tutorials will help you update your PR. These documentations provide information to correctly and properly implement visualization packages and register the package.
- How to Implement Your Own Visualization Function
- How to Register Your Algorithm with OptunaHub
- How to Debug Your Algorithm Before Registering in OptunaHub
Seeing PRs already merged to add visualization functionalities, e.g., #144, is also an excellent way to understand the proper process.
If you have any difficulties fixing the PR, please let me know.
test_optu.py
Outdated
module = optunahub.load_module( | ||
package="optuna_enhanced_visualization", | ||
repo_owner="nourbc211", | ||
ref="main", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not load the package from your fork of optunahub-registry.
I think this test file can be removed since it simply loads the module.
module = optunahub.load_module( | |
package="optuna_enhanced_visualization", | |
repo_owner="nourbc211", | |
ref="main", | |
) | |
module = optunahub.load_module( | |
package="visualization/optuna_enhanced_visualization", | |
) |
|
||
```python | ||
import optuna | ||
from optuna_enhanced_visualization import plot_optimization_history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use optunahub.load_module
to load your package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback! I'll make the changes asap
i have an issue caused by the readme file when pre-commit/action but i don't see where the problem could be. the .pre-commit-config.yaml is supposed to exclude this file anyway. Do you have an idea of what i could do to fix it ? |
Your README may have a format error. Please correct the format carefully. I discovered a problem. fig = plot_optimization_history(
study,
display_param_label=True,
view_x_in_log_scale=False,
display_log_difference=True,
)
fig.show()
|
Due to a lack of reaction, I close this PR. If you want to continue working on this task, please reopen this PR. |
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Motivation
This pull request enhances Optuna’s visualization by introducing new customization options, improving the clarity and interpretability of optimization history plots.Originally, this feature was proposed in the main Optuna repository, but it was suggested by a maintainer that OptunaHub would be a more suitable location.
Description of the changes
TODO List towards PR Merge
Please remove this section if this PR is not an addition of a new package.
Otherwise, please check the following TODO list:
./template/
to create your package<COPYRIGHT HOLDER>
inLICENSE
of your package with your nameREADME.md
in your package__init__.py
from __future__ import annotations
at the head of any Python files that include typing to support older Python versionsREADME.md
README.md