Follow the Optuna convention #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I modified your code, so could you take a look if you are fine with these changes? |
btjanaka
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Hi @nabenabe0928, I think these changes make a lot of sense! I have some mostly minor comments.
package/samplers/cmamae/example.py
Outdated
| """Returns an objective followed by two measures.""" | ||
| x = trial.suggest_float("x", -10, 10) | ||
| y = trial.suggest_float("y", -10, 10) | ||
| return x**2 + y**2, x, y | ||
| trial.set_user_attr("x", x) |
There was a problem hiding this comment.
I would set the measure names to be m0 and m1 rather than x and y so that it is more clear that measure names need not be the same as the parameters. For example, we could easily have:
trial.set_user_attr("m0", 2 * x)
trial.set_user_attr("m1", x + y)
package/samplers/cmamae/README.md
Outdated
| """Returns an objective followed by two measures.""" | ||
| x = trial.suggest_float("x", -10, 10) | ||
| y = trial.suggest_float("y", -10, 10) | ||
| return x**2 + y**2, x, y | ||
| trial.set_user_attr("x", x) |
There was a problem hiding this comment.
Same comment as in example.py
|
@btjanaka |
|
@nabenabe0928 It looks good to me! Thank you again! |
|
@gen740 Could you review this PR? |
c-bata
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor Agreements
Please read the contributor agreements and if you agree, please click the checkbox below.
Motivation
Let Pyribs follow the Optuna convention.