Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks tutorials #202

Merged
merged 23 commits into from
Dec 12, 2024
Merged

Conversation

y0z
Copy link
Member

@y0z y0z commented Dec 9, 2024

Contributor Agreements

Please read the contributor agreements and if you agree, please click the checkbox below.

  • I agree to the contributor agreements.

Tip

Please follow the Quick TODO list to smoothly merge your PR.

Motivation & Description of the changes

This PR adds tutorials on benchmarks.
Please merge optuna/optunahub#73 before merging this PR since this PR requires the optunahub.benchmarks module that has not been merged into the master branch of optunahub.

recipes/002_registration.py Outdated Show resolved Hide resolved
recipes/002_registration.py Outdated Show resolved Hide resolved
recipes/002_registration.py Outdated Show resolved Hide resolved
@nabenabe0928
Copy link
Contributor

nabenabe0928 commented Dec 11, 2024

I think here needs to be updated as well.

- ``tags`` (list[string]): The package tags. It should be a list of strings. The tags must include ``sampler``, ``visualization``, or ``pruner`` depending on the type of the package. You can add other tags as needed. For example, "['sampler', 'LLM']".

@y0z
Copy link
Member Author

y0z commented Dec 11, 2024

#202 (comment)

Thank you. I addressed it.

recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/006_benchmarks_basic.py Outdated Show resolved Hide resolved
recipes/007_benchmarks_advanced.py Outdated Show resolved Hide resolved
recipes/007_benchmarks_advanced.py Outdated Show resolved Hide resolved
recipes/007_benchmarks_advanced.py Outdated Show resolved Hide resolved
recipes/007_benchmarks_advanced.py Outdated Show resolved Hide resolved
recipes/007_benchmarks_advanced.py Outdated Show resolved Hide resolved
y0z and others added 14 commits December 11, 2024 12:00
@y0z y0z marked this pull request as ready for review December 11, 2024 07:27
@y0z
Copy link
Member Author

y0z commented Dec 11, 2024

All suggestions have been applied. PTAL.

Copy link
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost LGTM!
As the last thing is to make the doc a bit more consistent and the other parts follow the same convention, I will commit it by myself and will merge this PR!

recipes/007_benchmarks_advanced.py Outdated Show resolved Hide resolved
@nabenabe0928 nabenabe0928 merged commit f7559fc into optuna:main Dec 12, 2024
4 checks passed
@y0z y0z deleted the feature/benchmarks-tutorial branch December 12, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants