-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust HEBO to FloatDistribution
with step
#204
Merged
HideakiImamura
merged 13 commits into
optuna:main
from
nabenabe0928:adjust-hebo-to-float-with-step
Dec 19, 2024
Merged
Adjust HEBO to FloatDistribution
with step
#204
HideakiImamura
merged 13 commits into
optuna:main
from
nabenabe0928:adjust-hebo-to-float-with-step
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@y0z |
HideakiImamura
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@nabenabe0928 Could you resolve the conflict? |
I noticed that I need to transform before |
I fixed so that HEBO now knows the exact indices for each parameter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts
HEBOSampler
so that it can handleFloatDistribution
withstep
properly.Note
Originally,
HEBOSampler
falls back tosample_independent
if there are any parameters withFloatDistribution
andstep
.Please use the following objective function for the verification!