-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review the tutorial #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost, LGTM. I have a minor comment.
recipes/001_first.py
Outdated
@@ -185,7 +186,7 @@ def objective(trial: optuna.trial.Trial) -> float: | |||
# ``` | |||
# See `example.py <path/to/example.py>` for more details. | |||
# | |||
# - An `Others` section that describes other information about the package, like the reference to the original paper or the link to the source code. For example: | |||
# - An `Others` (COMMENT: miscellaneous is better) section that describes supplementary information about the package such as the paper reference or the original source code link. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the comment. I will apply this change after this PR.
@nabenabe0928 Could you resolve a conflict? |
Co-authored-by: Hideaki Imamura <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Contributor Agreements
Please read the CODE_OF_CONDUCT.md and if you agree, please click the checkbox below.
Motivation
I read the tutorial and left some enhancements.
Description of the changes