Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the tutorial #21

Merged
merged 5 commits into from
May 20, 2024
Merged

Review the tutorial #21

merged 5 commits into from
May 20, 2024

Conversation

nabenabe0928
Copy link
Contributor

Contributor Agreements

Please read the CODE_OF_CONDUCT.md and if you agree, please click the checkbox below.

  • I agree to the code of conduct.

Motivation

I read the tutorial and left some enhancements.

Description of the changes

recipes/001_first.py Outdated Show resolved Hide resolved
Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, LGTM. I have a minor comment.

recipes/001_first.py Outdated Show resolved Hide resolved
@@ -185,7 +186,7 @@ def objective(trial: optuna.trial.Trial) -> float:
# ```
# See `example.py <path/to/example.py>` for more details.
#
# - An `Others` section that describes other information about the package, like the reference to the original paper or the link to the source code. For example:
# - An `Others` (COMMENT: miscellaneous is better) section that describes supplementary information about the package such as the paper reference or the original source code link. For example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment. I will apply this change after this PR.

recipes/001_first.py Outdated Show resolved Hide resolved
@HideakiImamura
Copy link
Member

@nabenabe0928 Could you resolve a conflict?

Copy link
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HideakiImamura HideakiImamura merged commit 6f7063f into main May 20, 2024
4 checks passed
@HideakiImamura HideakiImamura deleted the doc/review-tutorial branch May 20, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants