[DRCC][Ready to Merge] AQUA MS Enhancements #1058
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
kumar-shivam-ranjan
changed the base branch from
main
to
feature/aqua_ms_changes_2
kumar-shivam-ranjan
changed the base branch from
feature/aqua_ms_changes_2
to
main
kumar-shivam-ranjan
changed the base branch from
main
to
feature/aqua_ms_changes_2
# Conflicts: # ads/aqua/evaluation/evaluation.py
kumar-shivam-ranjan
changed the title
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
| ) | ||
| dsc_model.get_custom_metadata_artifact(EVALUATION_REPORT_MD, temp_dir) | ||
| dsc_model.get_custom_metadata_artifact(EVALUATION_REPORT_JSON, temp_dir) | ||
| else: |
There was a problem hiding this comment.
I think we should try to fetch from the artifacts as well at first, and then form OSS
There was a problem hiding this comment.
Sorry I thought i misunderstood this comment.
Not sure if i still understand
For Evaluation , we are fetching the reports first from metadata artifact , if not found ,we fetch from OSS.
There was a problem hiding this comment.
Ohh , I see you mean from model artifact? Yes we can do that.
Currently , we check in custom metadata. if not found , we check in customer's OSS bucket where evaluation reports are stored.
There was a problem hiding this comment.
Updated. @mrDzurb
| @@ -1376,11 +1405,10 @@ def delete(self, eval_id): | |||
|
|
|||
| @staticmethod | |||
| @fire_and_forget | |||
| def _delete_job_and_model(job, model): | |||
| def _delete_job_and_model(job: DataScienceJob, model: DataScienceModel): | |||
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
ads/common/utils.py
Outdated
| @@ -64,6 +64,7 @@ | |||
| MAX_DISPLAY_VALUES = 10 | |||
|
|
|||
| UNKNOWN = "" | |||
| UNKNOWN_LIST = [] | |||
There was a problem hiding this comment.
NIT: I think we don't really need this. We can use the [] directly wherever we need this.
There was a problem hiding this comment.
Updated. Thanks!
|
📌 Cov diff with main: 📌 Overall coverage: |
kumar-shivam-ranjan
changed the title
kumar-shivam-ranjan
changed the title
|
📌 Cov diff with main: 📌 Overall coverage: |
Description
This PR intends to enhance the AQUA flow with the introduction of MS enhancements regarding defined and custom metadata artifact APIs.
Related PR
#1036
New APIs introduced
E2E Test results
https://confluence.oraclecorp.com/confluence/display/OCIODSC/%5BAQUA%5D+DRCC+changes+tests+for+AQUA+UI+and+ADS
Unit Tests