Fixed ads dataset key error #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lu-ohai
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
darenr
approved these changes
Apr 11, 2025
qiuosier
approved these changes
Apr 11, 2025
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
mrDzurb
approved these changes
Apr 11, 2025
| "last": desc["last"], | ||
| "mode": desc["top"], | ||
| "unique percentage": 100 * series.nunique() / series.size, | ||
| "first": desc["first"] if "first" in desc else None, |
There was a problem hiding this comment.
Why can't we use .get()?
"first": desc.get("first"),
There was a problem hiding this comment.
Wrote this just in case the desc doesn't have a get method, but if it always does I can change this to get
VipulMascarenhas
approved these changes
Apr 11, 2025
|
📌 Cov diff with main: No lines with coverage information in this diff. 📌 Overall coverage: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed ads dataset key error