Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/adding oracle apex #2952

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

gamagecb
Copy link

Added Apex 24.2 version

Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Mar 28, 2025

LICENSE UPL 1.0

Copyright (c) 2014-2017 Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a brand new file. It should be Copyright (c) 2025 Oracle and/or its affiliates.

Oracle no longer includes the phrase "all rights reserved"

Comment on lines +113 to +114
## Support

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no content for this section, it should be removed.


## Copyright

Copyright (c) 2014-2017 Oracle and/or its affiliates. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, the copyright date is incorrect and "all rights reserved" should be removed.


USER root
# Install Java 11 OpenJDK
RUN yum install -y java-11-openjdk-devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add && rm -rf /var/cache/yum to this directive to reduce the size of the layer.

@@ -0,0 +1,28 @@
# Use Oracle 19c image as the base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a copyright header to this file.

Comment on lines +86 to +87
SysPassw0rd
ApexPassw0rd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oracle does not permit the use of fixed passwords. These need to be randomly generated at runtime.

@@ -0,0 +1,81 @@
# LICENSE UPL 1.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit backup/old files. This should be removed.

@@ -0,0 +1,21 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a copyright header

@@ -0,0 +1,37 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a copyright header

Comment on lines +6 to +7
Follow the instructions on the Docker official documentation to install Docker Desktop on Windows:
- [Docker Desktop Installation for Windows](https://docs.docker.com/desktop/install/windows-install/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should provide instructions for how to deploy this on Oracle Linux using Podman, as this would be the most common deployment scenario on an OCI instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants