Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to get the liquibase 4.23.0 metadata #545

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antoinebhs
Copy link

What does this PR do?

I would like to help to add liquibase metadata for version 4.26.0 in reference to this opened issue: #431. I would need the updated metadata in my project.

I first tried to get the same metadata as the 4.23.0 liquibase on master branch using generate-metadata.sh in this PR. I use 17.0.9-graal and try to get the metadata by running the existing tests in LiquibaseCoreTest.java.
There are a lot of differences between what is committed on master branch and what I get when I run the script to get metadata with the agent. I added my results to metadata/org.liquibase/liquibase-core/4.23.0/reflect-config.json and same for resource.json to see that it's very different.

For other projects like metadata/org.hibernate.orm/hibernate-core/6.6.0.Final which has a generate-metadata.sh script on master, I get much closer results.
My questions are:

  • how these metadata were obtained? Am I doing something wrong?
  • Is there a cleaning step? Can I have some details on this step if so?

Any help would make it much easier to contribute to the metadata repo!

@msupic do you have any insight on how you obtained these metadata for liquibase please?

Code sections where the PR accesses files, network, docker or some external service

  • (example link to code section)

Checklist before merging

@antoinebhs antoinebhs requested a review from a team as a code owner October 9, 2024 19:48
@antoinebhs antoinebhs requested a review from msupic October 9, 2024 19:48
@antoinebhs antoinebhs marked this pull request as draft October 9, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant