chore: store provenance asset info #975
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
benmss
force-pushed
the
819-store-provenance-asset-info
branch
from
7ced4d8 to
03ae1b2
Compare
benmss
force-pushed
the
819-store-provenance-asset-info
branch
from
03ae1b2 to
ede14d0
Compare
behnazh-w
reviewed
Apr 14, 2025
|
|
||
| #: The URL of the provenance asset. | ||
| provenance_asset_url: Mapped[str] = mapped_column(String, nullable=True) | ||
|
|
There was a problem hiding this comment.
Since you are adding these two columns, I was thinking to revisit this ORM mapping. Do you think
#: The release tag commit sha.
release_commit_sha: Mapped[str] = mapped_column(String, nullable=True)
#: The release tag.
release_tag: Mapped[str] = mapped_column(String, nullable=True)could be redundant since the commit_sha: Mapped[str] = mapped_column(String, nullable=True) should be the same as release tag?
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
Signed-off-by: Ben Selwyn-Smith <[email protected]>
benmss
force-pushed
the
819-store-provenance-asset-info
branch
from
ede14d0 to
e708d81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds provenance asset info to the database alongside the provenance it identifies. This was previously removed during refactoring.
Closes #819