Skip to content

Commit

Permalink
#minor Fixes for minor issues on event messages
Browse files Browse the repository at this point in the history
  • Loading branch information
kumarmanishbit committed May 5, 2022
1 parent 76f280b commit b5c1372
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ protected function _prepareForm()
0 => __('No'),
1 => __('Yes')
],
'note' => __('Oracle Connector will required network communication to the admin store. If your admin store is protected by Basic Auth, then select <em>Yes</em>, and fill in the username and password below. If your admin store is protected by a firewall, then you must allow network communication for incoming and outgoing requests to <strong>middleware.oracleps.com</strong> and <strong>sarlacc.oracleps.com</strong>. Your credentials are only used for Oracle Connector communication on encrypted channels.')
'note' => __('Oracle Connector will required network communication to the admin store. If your admin store is protected by Basic Auth, then select <em>Yes</em>, and fill in the username and password below. If your admin store is protected by a firewall, then you must allow network communication for incoming and outgoing requests to <strong>apps.p02.eloqua.com</strong>. Your credentials are only used for Oracle Connector communication on encrypted channels.')
]);

$username = $fieldset->addField('username', 'text', [
Expand Down
2 changes: 1 addition & 1 deletion Oracle/M2/Connector/Event/Platform.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Platform implements PlatformInterface
const RESPONSYS_EVENT_URL_OVERRIDE_KEY = 'RESPONSYS_EVENT_URL';
// This is a placeholder url, and it will change based on the environment where we deploy the app.
// replace APP_HOST with the actual url.
const RESPONSYS_EVENT_URL = 'http://localhost:8082/ecom/ams/app/magento/application/request/message/ingest';
const RESPONSYS_EVENT_URL = 'https://apps.p02.eloqua.com/ecom/ams/app/magento/application/request/message/ingest';

/** @var \Oracle\M2\Common\Transfer\Adapter */
protected $_client;
Expand Down
4 changes: 2 additions & 2 deletions Oracle/M2/Connector/Middleware.php
Original file line number Diff line number Diff line change
Expand Up @@ -764,10 +764,10 @@ protected function _sectionWalk($section, $scopeName, $scopeId, $endpoint, $call
foreach ($object['fields'] as $field) {
// have to change this
// $field['value'] = ($field['value'] === 'true');
if($field['value'] == "true") {
if($field['value'] === "true") {
$field['value'] = true;
}
if($field['value'] == "false") {
if($field['value'] === "false") {
$field['value'] = false;
}
if(is_numeric($field['value'])) {
Expand Down
2 changes: 1 addition & 1 deletion Oracle/M2/Impl/Core/Meta.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
class Meta implements \Oracle\M2\Core\MetaInterface
{

const EXTENSION_VERSION = '0.0.1';
const EXTENSION_VERSION = '0.1.0';

protected $_meta;
protected $_config;
Expand Down
6 changes: 4 additions & 2 deletions Oracle/M2/Order/Event/Source.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ public function getEventType()
public function action($order)
{
$orderService = $this->_connector->isOrderService('store', $order->getStoreId());
$imports = $this->orderHelper->getImportStatus('store', $order->getStoreId());
$deletes = $this->orderHelper->getDeleteStatus('store', $order->getStoreId());
//$imports = $this->orderHelper->getImportStatus('store', $order->getStoreId());
//$deletes = $this->orderHelper->getDeleteStatus('store', $order->getStoreId());
$imports = array("pending", "complete", "processing");
$deletes = array("holded", "canceled", "closed");
if (in_array($order->getStatus(), $imports)) {
return self::ADD_ACTION;
} elseif (in_array($order->getStatus(), $deletes)) {
Expand Down

0 comments on commit b5c1372

Please sign in to comment.