Skip to content

allow -S to specify search path #3081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2020
Merged

allow -S to specify search path #3081

merged 2 commits into from
Mar 20, 2020

Conversation

vladak
Copy link
Member

@vladak vladak commented Mar 19, 2020

Implementing the idea from #3071 (comment)

@vladak vladak force-pushed the indexer_search_path branch from 68d5eea to f9cba57 Compare March 20, 2020 10:48
@vladak vladak force-pushed the indexer_search_path branch from 54ea47f to f31db89 Compare March 20, 2020 12:14
idodeclare
idodeclare approved these changes Mar 20, 2020
View reviewed changes
Copy link
Contributor

@idodeclare idodeclare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Cool. I didn't know we supported options with optional arguments. I'm going to refactor -h,--help to use an optional argument to get the various details we offer instead of my clumsy -h -h -h.

@vladak vladak merged commit 3b65bef into oracle:master Mar 20, 2020
@vladak vladak deleted the indexer_search_path branch March 20, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idodeclare idodeclare idodeclare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vladak @idodeclare