-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix identity domain destruction by deactivating the identity domain before deletion #1782
base: master
Are you sure you want to change the base?
Conversation
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
4ceb46c
to
c826ae4
Compare
c826ae4
to
3bef0c5
Compare
3bef0c5
to
f8222f0
Compare
f8222f0
to
509df0e
Compare
509df0e
to
1de8fed
Compare
Can someone from Oracle can take this over even the PR contributor has not signed the OCA !? |
@thpham, oracle has approved my OCA, but it seems they don't really accept external contributions for this project. |
1de8fed
to
762cc89
Compare
762cc89
to
bd53691
Compare
Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time. Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI. We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards. We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution. |
bd53691
to
f807c08
Compare
f807c08
to
ea5aa29
Compare
ea5aa29
to
979b5b0
Compare
979b5b0
to
06db50f
Compare
The current implementation for deleting an identity domain attempts to call delete on it immediately. This will fail because an identity domain must be deactivated before it can be deleted. See API reference: https://docs.oracle.com/en-us/iaas/api/#/en/identity/20160918/Domain/DeleteDomain
This PR fixes the issue by deactivating the identity domain and waiting until it is marked as deactivated before attempting to delete it.
Closes #1781