Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oci_certificates_certificate_bundle and oci_certificates_certificate_authority_bundle data sources #1796

Closed
wants to merge 28 commits into from

Conversation

F21
Copy link

@F21 F21 commented Mar 9, 2023

This PR implements the oci_certificates_certificate_bundle and oci_certificates_certificate_authority_bundle data sourcse.
It uses the GetCertificateBundle and GetCertificateAuthorityBundle methods that are part of the Certificates Service Retrieval API.

As part of this change, I had to update github.com/hashicorp/terraform-json as it was causing tests to fail due to terraform state version incompatibilities. The vendor folder was also updated with these dependencies.

Relates to #1792

Test results for oci_certificates_certificate_bundle:

$ make testacc make testacc TESTARGS='-run=TestCertificatesCertificateBundleResource'
==> Checking that code complies with gofmt requirements...
export GO111MODULE=on
export GOFLAGS=-mod=vendor
go install
TF_ACC=1   go test ./... -v -run=TestCertificatesCertificateBundleResource     -timeout  120m
?       github.com/oracle/terraform-provider-oci        [no test files]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/coverage       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/httpreplay     (cached) [no tests to run]
?       github.com/oracle/terraform-provider-oci/internal/client        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/globalvar     [no test files]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/acctest       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/commonexport  (cached) [no tests to run]
?       github.com/oracle/terraform-provider-oci/internal/service/adm   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ai_anomaly_detection  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ai_vision     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/analytics     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/announcements_service [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apigateway    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm_config    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm_synthetics        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm_traces    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/appmgmt_control       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/artifacts     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/audit [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/autoscaling   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/bastion       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/bds   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/blockchain    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/budget        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/certificates  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/certificates_management       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/cloud_bridge  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/cloud_guard   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/cloud_migrations      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/computeinstanceagent  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/container_instances   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/containerengine       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/core  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/data_safe     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/data_labeling_service [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/data_connectivity     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database_management   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database_migration    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database_tools        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/datacatalog   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/dataintegration       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/integration   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/jms   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/kms   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/license_manager       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/limits        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/load_balancer [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/log_analytics [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/logging       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/management_agent      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/management_dashboard  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/marketplace   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/media_services        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/metering_computation  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/monitoring    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/mysql [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/network_firewall      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/network_load_balancer [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/nosql [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/objectstorage [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/oce   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ocvp  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/oda   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/onesubscription       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ons   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/opa   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/opensearch    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/operator_access_control       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/opsi  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/optimizer     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osmanagement  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osp_gateway   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_billing_schedule [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_organization_subscription        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_subscription     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_usage    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/queue [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/recovery      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/resourcemanager       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/sch   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/secrets       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/service_catalog       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/service_manager_proxy [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/service_mesh  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/stack_monitoring      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/streaming     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/usage_proxy   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vault [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vbs_inst      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/visual_builder        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vn_monitoring [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vulnerability_scanning        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/waa   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/waas  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/waf   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/disaster_recovery     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/dns   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/em_warehouse  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/email [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/generic_artifacts_content     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/golden_gate   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/functions     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/fusion_apps   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/health_checks [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/identity_data_plane   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/identity      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/events        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/datascience   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/dataflow      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/file_storage  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/devops        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/utils [no test files]
=== RUN   TestCertificatesCertificateBundleResource_basic
2023/03/09 14:27:52 bypassing.go:20: Not recording. TestCertificatesCertificateBundleResource_basic
--- PASS: TestCertificatesCertificateBundleResource_basic (23.29s)
PASS
ok      github.com/oracle/terraform-provider-oci/internal/integrationtest       23.827s
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/provider      (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/resourcediscovery     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/tfresource    (cached) [no tests to run]
make: *** No rule to make target 'make'.  Stop.

Test results for oci_certificates_certificate_authority_bundle:

$ make testacc TESTARGS='-run=TestCertificatesCertificateAuthorityBundleResource'
==> Checking that code complies with gofmt requirements...
export GO111MODULE=on
export GOFLAGS=-mod=vendor
go install
TF_ACC=1   go test ./... -v -run=TestCertificatesCertificateAuthorityBundleResource     -timeout  120m
?       github.com/oracle/terraform-provider-oci        [no test files]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/coverage       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/httpreplay     (cached) [no tests to run]
?       github.com/oracle/terraform-provider-oci/internal/client        [no test files]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/acctest       (cached) [no tests to run]
?       github.com/oracle/terraform-provider-oci/internal/globalvar     [no test files]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/commonexport  (cached) [no tests to run]
?       github.com/oracle/terraform-provider-oci/internal/service/adm   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ai_anomaly_detection  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ai_vision     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/analytics     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/announcements_service [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apigateway    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm_config    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm_synthetics        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/apm_traces    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/appmgmt_control       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/artifacts     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/audit [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/autoscaling   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/bastion       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/bds   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/blockchain    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/budget        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/certificates  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/certificates_management       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/cloud_bridge  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/cloud_guard   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/cloud_migrations      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/computeinstanceagent  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/container_instances   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/containerengine       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/core  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/data_connectivity     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/data_labeling_service [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/data_safe     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database_management   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database_migration    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/database_tools        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/datacatalog   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/dataflow      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/dataintegration       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/datascience   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/devops        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/disaster_recovery     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/dns   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/em_warehouse  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/email [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/events        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/file_storage  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/functions     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/fusion_apps   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/generic_artifacts_content     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/golden_gate   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/health_checks [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/identity      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/identity_data_plane   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/integration   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/jms   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/kms   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/license_manager       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/limits        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/load_balancer [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/log_analytics [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/logging       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/management_agent      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/management_dashboard  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/media_services        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/marketplace   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/metering_computation  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/monitoring    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/mysql [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/network_firewall      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/network_load_balancer [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/nosql [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/objectstorage [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/oce   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ocvp  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/oda   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/onesubscription       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/ons   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/opa   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/opensearch    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/operator_access_control       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/opsi  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/optimizer     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osmanagement  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osp_gateway   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_billing_schedule [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_organization_subscription        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_subscription     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/osub_usage    [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/queue [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/recovery      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/resourcemanager       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/sch   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/secrets       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/service_catalog       [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/service_manager_proxy [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/service_mesh  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/stack_monitoring      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/streaming     [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/usage_proxy   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vault [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vbs_inst      [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/waf   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vn_monitoring [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/vulnerability_scanning        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/waa   [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/waas  [no test files]
?       github.com/oracle/terraform-provider-oci/internal/service/visual_builder        [no test files]
?       github.com/oracle/terraform-provider-oci/internal/utils [no test files]
=== RUN   TestCertificatesCertificateAuthorityBundleResource_basic
2023/03/10 14:19:58 bypassing.go:20: Not recording. TestCertificatesCertificateAuthorityBundleResource_basic
--- PASS: TestCertificatesCertificateAuthorityBundleResource_basic (45.49s)
PASS
ok      github.com/oracle/terraform-provider-oci/internal/integrationtest       45.996s
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/provider      (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/resourcediscovery     (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/oracle/terraform-provider-oci/internal/tfresource    (cached) [no tests to run]

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 9, 2023
@F21 F21 force-pushed the certificates-data-sources branch 2 times, most recently from 737e10a to 53f13b2 Compare March 10, 2023 03:22
@F21 F21 changed the title Add oci_certificates_certificate_bundle data source Add oci_certificates_certificate_bundle and oci_certificates_certificate_authority_bundle data sources Mar 10, 2023
@F21 F21 force-pushed the certificates-data-sources branch from 53f13b2 to 9a0b2a5 Compare March 15, 2023 21:57
@F21 F21 force-pushed the certificates-data-sources branch from 9a0b2a5 to ba26d74 Compare March 31, 2023 03:46
@F21 F21 force-pushed the certificates-data-sources branch from ba26d74 to 6dd277e Compare April 24, 2023 22:30
@F21 F21 force-pushed the certificates-data-sources branch from 6dd277e to 55b6910 Compare May 25, 2023 22:35
@F21 F21 force-pushed the certificates-data-sources branch from 55b6910 to 0e3c704 Compare July 20, 2023 23:21
@tf-oci-pub tf-oci-pub added the Pending Test Pending Test label for PRs label Aug 28, 2023
@tf-oci-pub
Copy link
Member

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

@ravinitp
Copy link
Member

@F21 There are so many changes in this PR. Please rebase and recreate the PR.

@F21
Copy link
Author

F21 commented Aug 29, 2023

Superseded by #1951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. Pending Test Pending Test label for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants