-
Notifications
You must be signed in to change notification settings - Fork 700
Implement schedule_deletion_days
field for KMS vaults and keys
#1987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Implement schedule_deletion_days
field for KMS vaults and keys
#1987
Conversation
Signed-off-by: Brian Zoetewey <[email protected]>
Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time. Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI. We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards. We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution. |
I am unable to run acceptance tests for this project. It appears that tests must be run with an older version of Terraform (0.12.x ?) which doesn't exist for my architecture (darwin-arm64).
|
I was able to run test locally after bumping the
|
This adds a field called
schedule_deletion_days
to the following resources:oci_kms_vault
oci_kms_key
oci_kms_key_version
oci_vault_secret
This allows Terrafrom to automatically set the value of
TimeOfDeletion
on a ScheduleDeletion API call when a resource is destroyed. If a resource already hastime_of_deletion
set, it will take precedence over theschedule_deletion_days
field.Implements #1986