Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue oracle#1477 #2240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

daniel-pro
Copy link

This is the fix for the issue : oci_certificates_management_certificate fails with config_type="IMPORTED" #1477

All credits to @bscarbrough

This is the fix for the issue :  oci_certificates_management_certificate fails with config_type="IMPORTED" oracle#1477 

All credits to @bscarbrough
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Nov 8, 2024
@daniel-pro
Copy link
Author

daniel-pro commented Nov 8, 2024

I've just signed the OCA, is it possibile to check, confirm and move on with the PR ?
Thanks,
Daniel

@tf-oci-pub
Copy link
Member

Thank you for your valuable contribution. We greatly appreciate your efforts in submitting this pull request. However, I regret to inform you that we are unable to merge it directly on GitHub at this time.

Our internal policy requires that all pull requests undergo thorough local testing and review before they can be merged into the main codebase. This process ensures the quality and stability of Terraform-Provider-OCI.

We understand that this may cause some inconvenience, but please rest assured that your contribution is highly valued. Our team will carefully review and test your changes locally to ensure they meet our standards.

We appreciate your understanding and patience in this matter. If you have any questions or need further assistance, please don't hesitate to reach out. Thank you once again for your contribution.

Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Nov 11, 2024
@passoszup
Copy link

It's enough to be a shame for others to not approve a correction for a two-year-old bug without assistance. Not to mention the lack of commitment to OCI users. Well, the OCI really needs to improve, but a lot, the problem is that there doesn't seem to be the slightest commitment to achieving this.

@bscarbrough
Copy link

Yeah, I think Oracle believes they are doing this for our own good. It seems they know how to manage security for my organization better than I do. Even though I've taken multiple steps to ensure our processes and certs are handled securely, that doesn't seem to matter since "the all-knowing Oracle" knows best...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. Pending Test Pending Test label for PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants