Feat/oraidex support converter #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
trung2891
commented
Sep 30, 2024
trung2891
commented
- Support convert asset
ducphamle2
reviewed
Sep 30, 2024
| let pool_key = convert_pool_id_to_v3_pool_key(&operation.pool)?; | ||
| let x_to_y = pool_key.token_x == operation.denom_in; | ||
| hop_swap_requests.push(OraidexSwapOperation::SwapV3 { pool_key, x_to_y }); | ||
| } else { |
There was a problem hiding this comment.
Should we specifically check if the operation is swap v2? A fallback to v2 can be risky. We can fallback to an error if the operation is neither v3 or v2
There was a problem hiding this comment.
we default swap through v2 if poolID is not of v3 format. Pool V2 only needs denom_in & denom_out to determine pool, and if this pool doesn't exist, it will throw pool not found in factory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.