Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: searchbox as modal layout #43

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Conversation

faustoq
Copy link
Member

@faustoq faustoq commented Oct 4, 2024

  • Added support for Search placeholder
  • Added new prop for Chat placeholder (we can remove/deprecate the old placeholder in another release)
  • Minor fixes to SearchBox stories (controls, defaults, etc.)
  • SearchBox layouts:
    • modal (default)
    • embed

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-ui-components-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 4:20pm

@g-francesca
Copy link
Contributor

@faustoq I left some comments. On UI seems everything is working great. I just noticed these small things to fix:

Screenshot 2024-10-07 alle 12 33 40 There's some padding top to remove and border-radius (bottom left and right) have to be removed in this case. Screenshot 2024-10-07 alle 12 40 19 As we do per modal, I would set some max-height (maybe the same we use for the modal content), and then search results would scroll if they occupy more height. Now there's not limit in height

@faustoq faustoq merged commit a182aa4 into main Oct 7, 2024
3 checks passed
@faustoq faustoq deleted the feature/searchbox-as-modal-layout branch December 2, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants