-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: searchbox as modal layout #43
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
g-francesca
reviewed
Oct 7, 2024
g-francesca
reviewed
Oct 7, 2024
g-francesca
reviewed
Oct 7, 2024
packages/ui-stencil/src/components/internal/orama-sliding-panel/orama-sliding-panel.scss
Outdated
Show resolved
Hide resolved
g-francesca
reviewed
Oct 7, 2024
packages/ui-stencil/src/components/orama-search-box/orama-search-box.scss
Outdated
Show resolved
Hide resolved
g-francesca
reviewed
Oct 7, 2024
packages/ui-stencil/src/components/orama-search-box/orama-search-box.tsx
Outdated
Show resolved
Hide resolved
g-francesca
reviewed
Oct 7, 2024
packages/ui-stencil/src/components/internal/orama-sliding-panel/orama-sliding-panel.tsx
Outdated
Show resolved
Hide resolved
@faustoq I left some comments. On UI seems everything is working great. I just noticed these small things to fix: There's some padding top to remove and border-radius (bottom left and right) have to be removed in this case. As we do per modal, I would set some max-height (maybe the same we use for the modal content), and then search results would scroll if they occupy more height. Now there's not limit in height |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
placeholder
in another release)layouts
: