Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pop Over button position issue fixed #730

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

ShachiniMekala
Copy link

@ShachiniMekala ShachiniMekala commented Aug 2, 2023

Checklist

  • Test Coverage is 100% for the newly added code
  • Storybook stories are added/updated for the changed areas
  • Components standards defined in this document are followed
  • Code is linted properly
  • Developer testing is done for the affected areas
  • Package version updated (not applicable to ent branch)
  • Changelog.md updated on possible breaking (applicable to ent branch)

@rtamarasinghe
Copy link

Accepting merge since the wrongly spelled classes (positon) is used in multiple places already and changing it everywhere is complex, and can be done as a separate fix

@rtamarasinghe rtamarasinghe merged commit a6e9aa7 into orangehrm:ent Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants