Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: push an empty index when deleting the last referrer with SkipReferrersGC #593

Merged
merged 9 commits into from
Sep 12, 2023

Conversation

Wwwsylvia
Copy link
Member

@Wwwsylvia Wwwsylvia commented Sep 8, 2023

Fix: #592

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #593 (9272c93) into main (c130949) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #593      +/-   ##
==========================================
+ Coverage   74.36%   74.39%   +0.02%     
==========================================
  Files          58       58              
  Lines        5246     5252       +6     
==========================================
+ Hits         3901     3907       +6     
  Misses        991      991              
  Partials      354      354              
Files Changed Coverage Δ
registry/remote/repository.go 71.05% <100.00%> (+0.16%) ⬆️

📢 Have feedback on the report? Share it here.

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Copy link
Contributor

@qweeah qweeah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but IANAM

Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 577bffe into oras-project:main Sep 12, 2023
7 checks passed
@Wwwsylvia Wwwsylvia deleted the fix_skipGC branch September 12, 2023 02:02
Wwwsylvia added a commit to Wwwsylvia/oras-go that referenced this pull request Oct 19, 2023
shizhMSFT pushed a commit that referenced this pull request Oct 20, 2023
@Wwwsylvia Wwwsylvia mentioned this pull request Oct 20, 2023
4 tasks
@Wwwsylvia Wwwsylvia mentioned this pull request Jan 26, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referrers tag index is not updated when all referrers are removed and GC is skipped
5 participants