fix: Avoid a copy of sync.Mutex in Repository #603
Conversation
ktarplee
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
ktarplee
force-pushed
the
600-sibling
branch
from
295a613 to
2918d37
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #603 +/- ##
==========================================
+ Coverage 74.64% 74.67% +0.02%
==========================================
Files 59 59
Lines 5266 5271 +5
==========================================
+ Hits 3931 3936 +5
Misses 983 983
Partials 352 352
|
There was a problem hiding this comment.
nit: Can we follow the conventional commits to update the PR title?
ktarplee
force-pushed
the
600-sibling
branch
from
2918d37 to
9534aab
Compare
ktarplee
changed the title
ktarplee
force-pushed
the
600-sibling
branch
from
4642be4 to
3f0e8fc
Compare
|
@ktarplee Can we rebase this PR? |
ktarplee
force-pushed
the
600-sibling
branch
from
1325b43 to
eaa2324
Compare
Done |
|
This needs to be rebased again before we can merge it. |
sibling() was copying the entire Respoitory struct which contains a sync.Mutex. Added a clone() to consolidate the code that performs a limited copy. fix: added HandleWarning to clone() Signed-off-by: Kyle M. Tarplee <[email protected]>
Signed-off-by: Kyle M. Tarplee <[email protected]>
ktarplee
force-pushed
the
600-sibling
branch
from
eaa2324 to
9d1be18
Compare
I rebased it again. Why do you guys care so much about linear Git history? It seems like an unnecessary obstacle to development efficiency and an issue with scaling to more developers. @Wwwsylvia |
@ktarplee Sorry for the inconvenience. Currently this repository is configured to allow squash merge only for a clearer Git history. @shizhMSFT may comment more on this. |
|
Conventional commits are also applied to this repository. However, it is too hard to enforce it for all contributors, especially beginners. Therefore, we choose "squash merge" as a workaround. |
|
I'm glad to contribute. I hope to have more to contribute in the future. |
Closes oras-project#600 Signed-off-by: Kyle M. Tarplee <[email protected]>
Closes #600 Signed-off-by: Kyle M. Tarplee <[email protected]>
Closes #600