-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: bump github.com/opencontainers/image-spec
to v1.1.0-rc5
#615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Wwwsylvia
requested review from
sajayantony,
shizhMSFT and
SteveLasker
as code owners
October 11, 2023 10:00
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #615 +/- ##
=======================================
Coverage 74.59% 74.59%
=======================================
Files 58 58
Lines 5313 5313
=======================================
Hits 3963 3963
Misses 995 995
Partials 355 355
|
Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
shizhMSFT
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Wwwsylvia
added a commit
to Wwwsylvia/oras-go
that referenced
this pull request
Oct 19, 2023
…ras-project#615) 1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod 2. Replace "index.json" and "blobs" with corresponding constants in the spec 3. Fix testable examples that broke by the spec change - `MediaType` became a required field in `Descriptor` Resolve: oras-project#599 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
shizhMSFT
pushed a commit
that referenced
this pull request
Oct 20, 2023
) 1. Bump `github.com/opencontainers/image-spec` to `v1.1.0-rc5` in go mod 2. Replace "index.json" and "blobs" with corresponding constants in the spec 3. Fix testable examples that broke by the spec change - `MediaType` became a required field in `Descriptor` Resolve: #599 Signed-off-by: Lixia (Sylvia) Lei <[email protected]>
Thanks for this. Glad to see #520 and opencontainers/image-spec#1071 come full circle :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/opencontainers/image-spec
tov1.1.0-rc5
in go modMediaType
became a required field inDescriptor
Resolve: #599