[RFC] Add Delete() to oci.Store. #620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Francis Laniel <[email protected]>
eiffel-fl
requested review from
sajayantony,
shizhMSFT,
SteveLasker and
Wwwsylvia
as code owners
|
Hi @eiffel-fl , thanks for the PR. We have merged PR #606, #607 and #608 that enhanced the |
|
Hi!
Awesome! I will test and review #614 as it tackles the same problem as my PR but in a proper way! Best regards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
First, I would like to thank you for the work done in #470.
I tried to use this function but had troubles as the
content.Storageinoci.Storedoes not implement theDeletefunction.I thought to add
Deletertooci.Storagebut then I got troubles during compilation withcas.Memory.So, I casted the
content.Storagetooci.Storagewhich is not really good but at least it works.As a consequence, I would like to get your feedback on how to permit
oci.StoretoDelete()descriptor in a proper way regarding the layers of abstraction you have.Best regards and thank you in advance.