Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: use new packing function in oras-go #1070

Merged
merged 3 commits into from
Aug 22, 2023
Merged

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Aug 22, 2023

What this PR does / why we need it:
This PR uses PackManifest in push and attach.

@qweeah qweeah marked this pull request as ready for review August 22, 2023 08:51
go.sum Outdated Show resolved Hide resolved
Signed-off-by: Billy Zha <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #1070 (028e6e5) into main (30abae3) will decrease coverage by 0.08%.
The diff coverage is 80.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   80.01%   79.93%   -0.08%     
==========================================
  Files          56       56              
  Lines        2897     2896       -1     
==========================================
- Hits         2318     2315       -3     
- Misses        402      404       +2     
  Partials      177      177              
Files Changed Coverage Δ
cmd/oras/internal/option/spec.go 85.18% <50.00%> (ø)
cmd/oras/root/push.go 75.00% <80.00%> (-0.15%) ⬇️
cmd/oras/root/attach.go 81.89% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@TerryHowe TerryHowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 742b044 into oras-project:main Aug 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants