Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new exact indicators at grid scale #846

Merged
merged 13 commits into from
Oct 4, 2023

Conversation

ebocher
Copy link
Member

@ebocher ebocher commented Sep 26, 2023

Here the list

  • ASPECT_RATIO (GeoClimate method https://github.com/orbisgis/geoclimate/wiki/RSU-indicators#aspect_ratio)
  • SVF (done with Ground Sky View Factor process)
  • HEIGHT_OF_ROUGHNESS_ELEMENTS (Geometric average of building heights (LCZs 1–10) and tree/plant heights (LCZs A–F) (m))
  • TERRAIN_ROUGHNESS_CLASS (Davenport et al.’s (2000) classification of effective terrain roughness (z0 ) for city and country landscapes)

@j3r3m1 @MGousseff

ebocher and others added 4 commits September 26, 2023 15:12
Improve some grid indicators to compute the exact part of geometry inside a grid cell
Update Groovy to 3.0.19 because 3.0.11 is no longer available on the groovy download page
@ebocher
Copy link
Member Author

ebocher commented Sep 29, 2023

The HEIGHT_OF_ROUGHNESS_ELEMENTS is not yet available because the effectiveTerrainRoughnessLength algorithm must be replaced by frontalAreaIndexDistribution to compute its exact value.

@ebocher
Copy link
Member Author

ebocher commented Sep 29, 2023

To limit the number of calls to basic geometric functions such as area, I suggest calculating them when the data is formatted.
e.g building layer must contains a column name area, perimeter...

@ebocher
Copy link
Member Author

ebocher commented Sep 29, 2023

projectedFacadeAreaDistribution and frontalAreaIndexDistribution do not used the same notation for the result columns.

The first one use XX_INDEX_H50_D0_30 and the second one XX_INDEX_H50_${layer_top}_D0_30

See : https://github.com/orbisgis/geoclimate/blob/master/geoindicators/src/main/groovy/org/orbisgis/geoclimate/geoindicators/RsuIndicators.groovy#L1940

@j3r3m1
Copy link
Collaborator

j3r3m1 commented Oct 2, 2023

The first one use XX_INDEX_H50_D0_30 and the second one XX_INDEX_H50_${layer_top}_D0_30

Seems more relevant to use the second notation: even though it induces longer column names, it is probably simpler to collect informations such as deltaH in the interval in the second case. Should we create an issue to solve this problem ?

@ebocher
Copy link
Member Author

ebocher commented Oct 3, 2023

Here we are ;-)

@ebocher ebocher marked this pull request as ready for review October 3, 2023 17:02
@ebocher ebocher requested a review from j3r3m1 October 3, 2023 17:02
@ebocher ebocher merged commit 85f04b8 into orbisgis:master Oct 4, 2023
1 check passed
@ebocher ebocher deleted the grid_indicators branch March 26, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants