Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve #863 #905

Merged
merged 7 commits into from
Jan 11, 2024
Merged

Solve #863 #905

merged 7 commits into from
Jan 11, 2024

Conversation

j3r3m1
Copy link
Collaborator

@j3r3m1 j3r3m1 commented Jan 9, 2024

This PR solves #863:

  • OSM buildings having no nb_lev information but building height < 3 m (and >0 m) are now considered as buildings (a new building having these properties has been added in the Redon sample)
  • modify the algorithm used to update building nb_lev after building height estimation. However, this fix is not perfect. Ideally, the same algorithm than for the formatting should be used to have a consistency of the method... --> a new issue should be opened or directly solved following this fix ?

Plus ideally, the formatHeightsAndNbLevels should be identical in BDTopo and OSM.

@ebocher ebocher merged commit 8d5254a into orbisgis:master Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants