Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify types #944

Merged
merged 15 commits into from
Mar 28, 2024
Merged

Modify types #944

merged 15 commits into from
Mar 28, 2024

Conversation

j3r3m1
Copy link
Collaborator

@j3r3m1 j3r3m1 commented Mar 14, 2024

Creates new categories for calculating the fraction of each building type according to #881.

Copy link
Member

@ebocher ebocher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. However, I'm still having some difficulty imagining the consequences for the urban_areas layer and its use to enrich building types.

@j3r3m1 j3r3m1 marked this pull request as ready for review March 19, 2024 10:05
@ebocher
Copy link
Member

ebocher commented Mar 20, 2024

I'll propose some adjustements in unit test.

@ebocher ebocher merged commit 8b0c16b into orbisgis:master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants