Skip to content

Commit

Permalink
Crate fix probes (#92)
Browse files Browse the repository at this point in the history
* fixed cratedb liveness and readiness probes

replace the curl which only looks at the headers with kubernetes native
httpGet action.
The other one cannot be replace with httpGet action as it inspects the
body of the response which httpGet is not able to do.

* increased supported cratedb version

* increased chart version

* set supported crate version to 4.6.7

* set supported crate version to 4.6.7

Co-authored-by: modularTaco <none>
  • Loading branch information
modularTaco authored Jul 21, 2022
1 parent 5d0440a commit 65c8808
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion charts/crate/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: 'CrateDB chart'
name: crate
version: 0.1.14
version: 0.1.15
icon: https://crate.io/wp-content/themes/webflow/images/logo-crate.png
sources:
- https://github.com/crate/crate
Expand Down
2 changes: 1 addition & 1 deletion charts/crate/README.MD
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ The following table lists the configurable parameters of the cratedb chart and t
|-----------------------------------|---------------------------------------------|-----------------------------------------------------|
| `replicaCount` | Amount of pods to spawn | `3` |
| `image.name` | The image to pull | `crate` |
| `image.tag` | The version of the image to pull | `4.2.1` |
| `image.tag` | The version of the image to pull | `4.6.7` |
| `image.pullPolicy` | The pull policy | `IfNotPresent` |
| `resources` | Any resources you wish to assign to the pod | `{}` |
| `persistentVolume.accessModes` | Persistent Volume access modes | `[ReadWriteOnce]` |
Expand Down
6 changes: 3 additions & 3 deletions charts/crate/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ spec:
fieldPath: metadata.name
{{- if .Values.livenessProbe.enabled }}
livenessProbe:
exec:
command: ["sh", "-c", "curl -I http://localhost:4200 2&>/dev/null | grep '\"200\" : true'"]
httpGet:
port: {{ .Values.service.adminName }}
initialDelaySeconds: {{ .Values.livenessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.livenessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.livenessProbe.failureThreshold }}
Expand All @@ -79,7 +79,7 @@ spec:
{{- if .Values.readinessProbe.enabled }}
readinessProbe:
exec:
command: ["sh", "-c", "curl http://localhost:4200 2&>/dev/null | grep '\"ok\" : true'"]
command: ["sh", "-c", "curl -s http://localhost:4200 | grep -q '\"ok\" : true,'"]
initialDelaySeconds: {{ .Values.readinessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.readinessProbe.failureThreshold }}
Expand Down
2 changes: 1 addition & 1 deletion charts/crate/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ app: crate

image:
name: crate
tag: 4.0.12
tag: 4.6.7
pullPolicy: IfNotPresent

service:
Expand Down

0 comments on commit 65c8808

Please sign in to comment.