feat(dsql-cluster): add DSQL Cluster resource #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corybekk
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Thanks Dan! This looks good to me. I used the script in your companion PR and successfully cleaned up the cluster with the new module.
output:
us-east-1 - DSQLCluster - arn:aws:dsql:us-east-1:449540884463:cluster/iiabt5az32iwdnj4xpxwl5mz3e - [Arn: "arn:aws:dsql:us-east-1:449540884463:cluster/iiabt5az32iwdnj4xpxwl5mz3e", CreationTime: "2025-03-11T16:40:26Z", DeletionProtectionEnabled: "true", Identifier: "iiabt5az32iwdnj4xpxwl5mz3e", Status: "ACTIVE"] - removed
Removal requested: 0 waiting, 0 failed, 410 skipped, 1 finished
Nuke complete: 0 failed, 410 skipped, 1 finished.
gsoria
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
This looks great! Tried it locally everything works well. Thanks Dan!
aws-nuke - 3.0.0-dev - dirty
Do you really want to nuke the account with the ID 299719426765 and the alias 'alias-299719426765'?
Do you want to continue? Enter account alias to continue.
> alias-299719426765
starting scan for resources
us-east-1 - DSQLCluster - arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry - [Arn: "arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry", CreationTime: "2025-03-11T21:49:06Z", DeletionProtectionEnabled: "true", Identifier: "euabt5bl6sdwetsn4cx7tri6ry", Status: "ACTIVE"] - would remove
Scan complete: 1 total, 1 nukeable, 0 filtered.
Do you really want to nuke the account with the ID 299719426765 and the alias 'alias-299719426765'?
Do you want to continue? Enter account alias to continue.
> alias-299719426765
us-east-1 - DSQLCluster - arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry - [Arn: "arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry", CreationTime: "2025-03-11T21:49:06Z", DeletionProtectionEnabled: "true", Identifier: "euabt5bl6sdwetsn4cx7tri6ry", Status: "ACTIVE"] - triggered remove
Removal requested: 1 waiting, 0 failed, 0 skipped, 0 finished
us-east-1 - DSQLCluster - arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry - [Arn: "arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry", CreationTime: "2025-03-11T21:49:06Z", DeletionProtectionEnabled: "true", Identifier: "euabt5bl6sdwetsn4cx7tri6ry", Status: "ACTIVE"] - waiting for removal
Removal requested: 1 waiting, 0 failed, 0 skipped, 0 finished
us-east-1 - DSQLCluster - arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry - [Arn: "arn:aws:dsql:us-east-1:299719426765:cluster/euabt5bl6sdwetsn4cx7tri6ry", CreationTime: "2025-03-11T21:49:06Z", DeletionProtectionEnabled: "true", Identifier: "euabt5bl6sdwetsn4cx7tri6ry", Status: "ACTIVE"] - removed
Removal requested: 0 waiting, 0 failed, 0 skipped, 1 finished
Nuke complete: 0 failed, 0 skipped, 1 finished.
Comment on lines
+98
to
+104
| // https://aws.amazon.com/rds/aurora/dsql/faqs/#:~:text=available%20in%20all-,AWS%20Regions,-%3F | ||
| // NOTE: us-west-2 (Oregon) is available as a witness region, but clusters cannot be created in this region | ||
| supportedRegions := []string{ | ||
| "us-east-1", | ||
| "us-east-2", | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for removal of DSQL Cluster resources for each currently supported region.
us-west-2is partially supported because it is able to be a "witness" region, but no Cluster can be created there. Allowing list attempts within the region was attempted and was found to lead to the following error: