Modernization #17
Merged
Modernization #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want tmp because the validation_spec.js files were failing due to file collisions in the way that it now runs (asynchronously)
This commit includes: * Readme update to use `jasmine` instead of the abandoned `jasmine-node` * validation_spec updated to use `tmp` to create a temporary file to validate against; the old logic looks like it was written for a synchronous runtime, and that's not how things work anymore. * htmlbook_spec update is just to remove an unneeded `require`
delfanbaum
force-pushed
the
modernization
branch
from
8b72008 to
fe608ad
Compare
ruralocity
approved these changes
Mar 20, 2025
| } | ||
|
|
||
| describe("htmlbook validations", function () { | ||
| it("BBEPart2", function (done) { | ||
| xit("BBEPart2", function (done) { |
There was a problem hiding this comment.
Do we need to keep these tests if they're no longer needed? Or figure out how to fix at some point?
There was a problem hiding this comment.
These have disappeared from the repo; I'd like to try and find them eventually, but maybe it's not worth it? I could go either way; this is not a heavily used part of Atlas (and in fact we recommend against it, strongly).
nadamsoreilly
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is to get
htmlbook.jsworking with the current LTS version of node.js (22.14).