-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to change disk log destination #148
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you create builder for set directory and also the set the folder name so it will be more flexible. because sometime user only want to change the folder name only.
@jefryjacky I don't quite understand your words... You could pass a directory name like |
I mean the "logger" the "logger" is hardcoded, I suggest to be able to custom that name. |
@jefryjacky If changing the subdirectory instead of "logger" is the only thing the coder wants to do, why doesn't him/her pass |
Sorry for the late response and thanks for the pull request. I wasn't able to review anything this time period. Apart from a few things, all looks good to me. Would you mind to make the following changes? Then we can merge and release a version for this.
|
I have changed some, but with one thing not sure: |
DiskLogStrategy
.DiskLogStrategy
fromCsvFormatStrategy
toDiskLogStrategy.Builder
.