-
-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(changelog): allow adding custom context #613
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Can you update one of the tests to verify the behavior of add_context
?
feedback from doing this pr:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
==========================================
+ Coverage 41.52% 41.90% +0.38%
==========================================
Files 15 15
Lines 1072 1079 +7
==========================================
+ Hits 445 452 +7
Misses 627 627
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for the feedback!
I'm curious if there will be a lot of formatting changes, but I guess it is worth a shot. Can you submit an issue for it?
Yeah, I guess it is better to use a fixed commit instead of last commit for the conventional commit tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This allows to add custom context from the users of
git_cliff_core
.Motivation and Context
I need this in release-plz to inject the crate name in the changelog.
I protyped this in release-plz/release-plz#1399
I guess other people would benefit from this kind of feature as well :)
How Has This Been Tested?
Locally on the branch I showed you.
Not sure if you want to add the method
add_context
(or a similar approach) to theChangelog
struct.Lmk if you prefer to inject the context in another way 👍
Screenshots / Logs (if applicable)
release-plz/release-plz#916 (comment)
It contains multiple changelog updates (one for each package) in the same changelog file 🤯
Types of Changes
Checklist: