Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs based on #143 #963

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

paul-uz
Copy link
Contributor

@paul-uz paul-uz commented Nov 22, 2024

Description

Updated Tip and Tricks docs based on the answer provided in #143

Motivation and Context

The docs were wrong

How Has This Been Tested?

The code itself I tested myself in a default toml config file.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paul-uz paul-uz requested a review from orhun as a code owner November 22, 2024 23:27
Copy link

welcome bot commented Nov 22, 2024

Thanks for opening this pull request! Please check out our contributing guidelines! ⛰️

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.40%. Comparing base (dbda091) to head (88aa511).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #963      +/-   ##
==========================================
+ Coverage   43.35%   43.40%   +0.06%     
==========================================
  Files          21       21              
  Lines        1712     1712              
==========================================
+ Hits          742      743       +1     
+ Misses        970      969       -1     
Flag Coverage Δ
unit-tests 43.40% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@paul-uz
Copy link
Contributor Author

paul-uz commented Nov 23, 2024

Not sure why its failing on "Continuous Integration / Check NodeJS tarball (pull_request) " :/

@orhun
Copy link
Owner

orhun commented Nov 23, 2024

Thanks! Don't mind the CI :)

@orhun orhun merged commit 09c0f90 into orhun:main Nov 23, 2024
66 of 67 checks passed
Copy link

welcome bot commented Nov 23, 2024

Congrats on merging your first pull request! ⛰️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants