Merge pull request bitcoin#1386 from jonasnick/fix-taproot-tweak-pubkey

BIP 341: Fix taproot_tweak_pubkey
ori-near · Jan 4, 2023 · c672558 · c672558
2 parents 15c8203 + be34027
commit c672558
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/bip-0341.mediawiki b/bip-0341.mediawiki
@@ -182,7 +182,10 @@ def taproot_tweak_pubkey(pubkey, h):
     t = int_from_bytes(tagged_hash("TapTweak", pubkey + h))
     if t >= SECP256K1_ORDER:
         raise ValueError
-    Q = point_add(lift_x(int(pubkey)), point_mul(G, t))
+    P = lift_x(int_from_bytes(pubkey))
+    if P is None:
+        raise ValueError
+    Q = point_add(P, point_mul(G, t))
     return 0 if has_even_y(Q) else 1, bytes_from_int(x(Q))
 
 def taproot_tweak_seckey(seckey0, h):