Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Address timestamps in unit tests #103

Merged
merged 3 commits into from
Jul 28, 2020
Merged

Draft: Address timestamps in unit tests #103

merged 3 commits into from
Jul 28, 2020

Conversation

chapinb
Copy link
Collaborator

@chapinb chapinb commented Jul 24, 2020

Closes #102

Removes the timestamp comparison from unit tests since the test is to confirm log levels and handlers, not necessarily the timestamp.

This should improve the reliability of the unit tests.

@chapinb chapinb requested a review from orlikoski July 24, 2020 12:23
@chapinb
Copy link
Collaborator Author

chapinb commented Jul 24, 2020

In Travis, it appears the tests complete on Linux, though the build fails:

Test Run Successful.
Total tests: 20
     Passed: 20
 Total time: 42.7038 Seconds
Calculating coverage result...
  Generating report '../lcov.info'
+--------+--------+--------+--------+
| Module | Line   | Branch | Method |
+--------+--------+--------+--------+
| CyLR   | 41.14% | 68%    | 50%    |
+--------+--------+--------+--------+
+---------+--------+--------+--------+
|         | Line   | Branch | Method |
+---------+--------+--------+--------+
| Total   | 41.14% | 68%    | 50%    |
+---------+--------+--------+--------+
| Average | 41.14% | 68%    | 50%    |
+---------+--------+--------+--------+
[...]
The command "if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then BUILD_ARCH=linux-x64 USE_CORERT=TRUE scripts/build.sh ; fi" exited with 1.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then BUILD_ARCH=linux-x64 USE_CORERT=TRUE scripts/package.sh ; fi
/home/travis/.travis/functions: line 109: scripts/package.sh: Permission denied
The command "if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then BUILD_ARCH=linux-x64 USE_CORERT=TRUE scripts/package.sh ; fi" exited with 126.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then PowerShell -File scripts/test_win.ps1 ; fi
The command "if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then PowerShell -File scripts/test_win.ps1 ; fi" exited with 0.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then PowerShell -File scripts/build_win.ps1 ; fi
The command "if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then PowerShell -File scripts/build_win.ps1 ; fi" exited with 0.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then PowerShell -File scripts/package_win.ps1 ; fi
The command "if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then PowerShell -File scripts/package_win.ps1 ; fi" exited with 0.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then BUILD_ARCH=osx-x64 USE_CORERT=TRUE scripts/test.sh ; fi
The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then BUILD_ARCH=osx-x64 USE_CORERT=TRUE scripts/test.sh ; fi" exited with 0.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then BUILD_ARCH=osx-x64 USE_CORERT=TRUE scripts/build.sh ; fi
The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then BUILD_ARCH=osx-x64 USE_CORERT=TRUE scripts/build.sh ; fi" exited with 0.
0.01s$ if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then BUILD_ARCH=osx-x64 USE_CORERT=TRUE scripts/package.sh ; fi
The command "if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then BUILD_ARCH=osx-x64 USE_CORERT=TRUE scripts/package.sh ; fi" exited with 0.

@chapinb chapinb changed the title Address timestamps in unit tests Draft: Address timestamps in unit tests Jul 24, 2020
chapinb added 2 commits July 24, 2020 13:19
This only impacts collection logs and is meant to supress warnings about
paths that are not accessible by the current account.
Removed unused warp packer
@orlikoski orlikoski merged commit ec7a671 into beta Jul 28, 2020
@orlikoski orlikoski deleted the issue-102 branch July 28, 2020 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants