Merge pull request #2 from Telemaco019/fix/docs

Fix/docs

.gitignore

@@ -42,3 +42,5 @@ backend.tfvars
 .terraform.lock.hcl
 
 .idea/
+
+examples/tests

docs/data-sources/datastore.md

@@ -42,6 +42,6 @@ data "azureml_datastores" "example" {
 - **last_modified_user_type** (String) The kind of user that last updated the datastore (Service Principal or User).
 - **storage_account_name** (String) The name of the Storage Account to which the datastore is linked to.
 - **storage_container_name** (String) The name of the Storage Container to which the datastore is linked to.
-- **storage_type** (String) The type of the storage to which the datstore is linked to. Possible values are: %!v(MISSING)
+- **storage_type** (String) The type of the storage to which the datstore is linked to. Possible values are: ["AzureFile" "AzureBlob" "AzureDataLakeGen1" "AzureDataLakeGen2" "AzureMySql" "AzurePostgreSql" "AzureSqlDatabase" "GlusterFs"]
 
 

docs/index.md

@@ -18,49 +18,16 @@ Principal specific to Terraform.
 terraform {
   required_providers {
     azureml = {
-      source  = "registry.terraform.io/Telemaco019/azureml"
-      version = "0.0.1"
+      source = "registry.terraform.io/Telemaco019/azureml"
     }
   }
 }
 
 provider "azureml" {
-  client_id       = var.client_id
-  client_secret   = var.client_secret
-  tenant_id       = var.tenant_id
-  subscription_id = var.subscription_id
-}
-
-data "azureml_datastore" "datastore" {
-  resource_group_name = var.resource_group_name
-  workspace_name      = var.workspace_name
-  name                = "test"
-}
-output "datastore" {
-  value = data.azureml_datastore.datastore
-}
-
-data "azureml_datastores" "datastores" {
-  resource_group_name = var.resource_group_name
-  workspace_name      = var.workspace_name
-}
-
-resource "azureml_datastore" "example" {
-  resource_group_name = var.resource_group_name
-  workspace_name      = var.workspace_name
-  name                = "example2"
-  description         = "example"
-  storage_type        = "AzureBlob"
-
-  storage_account_name   = "pippo"
-  storage_container_name = "example"
-
-  auth {
-    credentials_type = "ServicePrincipal"
-    client_id        = var.client_id
-    client_secret    = var.client_secret
-    tenant_id        = var.tenant_id
-  }
+  client_id       = ""
+  client_secret   = ""
+  tenant_id       = ""
+  subscription_id = ""
 }
 ```
 

docs/resources/datastore.md

@@ -40,7 +40,7 @@ resource "azureml_datastore" "example" {
 - **auth** (Block Set, Min: 1, Max: 1) (see [below for nested schema](#nestedblock--auth))
 - **name** (String) The name of the datastore.
 - **resource_group_name** (String) The name of the resource group of the Azure ML Workspace to which the datastore belongs to.
-- **storage_type** (String) The type of the storage to which the datstore is linked to. Possible values are: %!v(MISSING)
+- **storage_type** (String) The type of the storage to which the datstore is linked to. Possible values are: ["AzureFile" "AzureBlob" "AzureDataLakeGen1" "AzureDataLakeGen2" "AzureMySql" "AzurePostgreSql" "AzureSqlDatabase" "GlusterFs"]
 - **workspace_name** (String) The name of the Azure ML Workspace to which the datastore belongs to.
 
 ### Optional
@@ -65,7 +65,7 @@ resource "azureml_datastore" "example" {
 
 Required:
 
-- **credentials_type** (String) The type of credentials used for authenticating with the underlying storage. Possible values are: %!v(MISSING).
+- **credentials_type** (String) The type of credentials used for authenticating with the underlying storage. Possible values are: ["AccountKey" "Certificate" "None" "Sas" "ServicePrincipal" "SqlAdmin"].
 
 Optional:
 

examples/provider/provider.tf

@@ -1,47 +1,14 @@
 terraform {
   required_providers {
     azureml = {
-      source  = "registry.terraform.io/Telemaco019/azureml"
-      version = "0.0.1"
+      source = "registry.terraform.io/Telemaco019/azureml"
     }
   }
 }
 
 provider "azureml" {
-  client_id       = var.client_id
-  client_secret   = var.client_secret
-  tenant_id       = var.tenant_id
-  subscription_id = var.subscription_id
-}
-
-data "azureml_datastore" "datastore" {
-  resource_group_name = var.resource_group_name
-  workspace_name      = var.workspace_name
-  name                = "test"
-}
-output "datastore" {
-  value = data.azureml_datastore.datastore
-}
-
-data "azureml_datastores" "datastores" {
-  resource_group_name = var.resource_group_name
-  workspace_name      = var.workspace_name
-}
-
-resource "azureml_datastore" "example" {
-  resource_group_name = var.resource_group_name
-  workspace_name      = var.workspace_name
-  name                = "example2"
-  description         = "example"
-  storage_type        = "AzureBlob"
-
-  storage_account_name   = "pippo"
-  storage_container_name = "example"
-
-  auth {
-    credentials_type = "ServicePrincipal"
-    client_id        = var.client_id
-    client_secret    = var.client_secret
-    tenant_id        = var.tenant_id
-  }
+  client_id       = ""
+  client_secret   = ""
+  tenant_id       = ""
+  subscription_id = ""
 }

internal/provider/provider.go

@@ -5,6 +5,7 @@ import (
 	"github.com/Telemaco019/azureml-go-sdk/workspace"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"time"
 )
 
@@ -33,21 +34,29 @@ func New(version string) func() *schema.Provider {
 		p := &schema.Provider{
 			Schema: map[string]*schema.Schema{
 				"client_id": {
-					Type:     schema.TypeString,
-					Required: true,
+					Type:         schema.TypeString,
+					Required:     true,
+					ValidateFunc: validation.StringIsNotEmpty,
+					Description:  "The application ID of the Service Principal used for authenticating with Azure Machine Learning.",
 				},
 				"client_secret": {
-					Type:      schema.TypeString,
-					Required:  true,
-					Sensitive: true,
+					Type:         schema.TypeString,
+					Required:     true,
+					Sensitive:    true,
+					ValidateFunc: validation.StringIsNotEmpty,
+					Description:  "The client secret of the Service Principal used for authenticating with Azure Machine Learning.",
 				},
 				"tenant_id": {
-					Type:     schema.TypeString,
-					Required: true,
+					Type:         schema.TypeString,
+					Required:     true,
+					ValidateFunc: validation.StringIsNotEmpty,
+					Description:  "The ID of the home Tenant of the Service Principal used for authenticating with Azure Machine Learning.",
 				},
 				"subscription_id": {
-					Type:     schema.TypeString,
-					Required: true,
+					Type:         schema.TypeString,
+					Required:     true,
+					ValidateFunc: validation.StringIsNotEmpty,
+					Description:  "The Azure subscription ID on which the provider will operate.",
 				},
 			},
 			DataSourcesMap: map[string]*schema.Resource{