-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use creds helper #346
base: v3
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #346 +/- ##
=====================================
Coverage ? 53.64%
=====================================
Files ? 1
Lines ? 343
Branches ? 0
=====================================
Hits ? 184
Misses ? 121
Partials ? 38 ☔ View full report in Codecov by Sentry. |
In order to write automated tests for this PR we would need private image and docker credentials helper provisioned in CI. |
Could you show a screen cast of this working with a private repo please? :) |
ping @shaxbee please see above |
5799eff
to
e9f3b91
Compare
While the PR is being worked on I will mark it as a draft. That declutters our review backlog :) Once you're done with your changes and would like someone to review them, mark the PR as ready and request a review from one of the maintainers. Thank you! |
@shaxbee could you follow up here? This is a useful addition. |
Any news regarding this one? |
Support pulling images from registries using docker credentials helper.
Backported auth related changes from go-dockerclient, when image is not found locally and image contains registry name credential helper will be called when available.
Checklist
and signed the CLA.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got green light (please contact
[email protected]) from the maintainers to push
the changes.
works.
appropriate).