Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify issuer URL changes #1651

Merged
merged 2 commits into from
Feb 19, 2024
Merged

docs: clarify issuer URL changes #1651

merged 2 commits into from
Feb 19, 2024

Conversation

aeneasr
Copy link
Member

@aeneasr aeneasr commented Feb 13, 2024

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@vinckr vinckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its a bit vague for me when I need to do this.
"in some cases" - "it can be the case"

When do I need to change it:

  1. Always in the cases listed (primary CNAME changed/old project)
  2. If there is an error in OAuth2 and the cases listed apply (primary CNAME changed/old project)
    ?

@aeneasr
Copy link
Member Author

aeneasr commented Feb 14, 2024

that makes sense, thanks, will try to clarify

@aeneasr
Copy link
Member Author

aeneasr commented Feb 15, 2024

Done

@vinckr vinckr merged commit 0ae0026 into master Feb 19, 2024
9 checks passed
@vinckr vinckr deleted the issuer-url-change branch February 19, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants