-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: format updated_at as UNIX time stamp #3631
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3631 +/- ##
==========================================
- Coverage 76.18% 76.09% -0.09%
==========================================
Files 133 133
Lines 10043 10003 -40
==========================================
- Hits 7651 7612 -39
- Misses 1868 1869 +1
+ Partials 524 522 -2
|
var s string | ||
switch v := val.(type) { | ||
case string: | ||
s = v | ||
case fmt.Stringer: | ||
s = v.String() | ||
default: | ||
continue | ||
} | ||
t, err := time.Parse(time.RFC3339Nano, s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var s string | |
switch v := val.(type) { | |
case string: | |
s = v | |
case fmt.Stringer: | |
s = v.String() | |
default: | |
continue | |
} | |
t, err := time.Parse(time.RFC3339Nano, s) | |
t, err := time.Parse(time.RFC3339Nano, fmt.Sprintf("%s", s)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be fixed in the consent app IMO
In compliance with https://openid.net/specs/openid-connect-core-1_0.html#StandardClaims
Related issue(s)
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
[email protected]) from the maintainers to push
the changes.
works.
Further Comments